| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_execute_from_file, patch v10 |
| Date: | 2010-12-15 22:05:27 |
| Message-ID: | AANLkTinaTEfpADwgDiPV6r1xj7i=6do+r5tqQ4tqxciB@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 15, 2010 at 12:55, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> It seems like pg_read_binary_file() is good to have regardless of
>>> whatever else we decide to do here. Should we pull that part out and
>>> commit it separately?
>>
> The whole-file versions seem like a good idea - my only hesitation is,
> I'm not sure why we didn't include that functionality originally. It
> seems obviously useful, so does that mean that it was omitted on
> purpose for some reason?
I applied the attached patch extracted from Dimitri's work.
One difference is 'offset' argument is removed from 'whole' mode.
So, we'll have (path, offset, length) and (path) versions.
Checking with convert_and_check_filename is left as-is.
--
Itagaki Takahiro
| Attachment | Content-Type | Size |
|---|---|---|
| pg_read_binary_file.patch | application/octet-stream | 9.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-12-15 22:56:15 | Re: Default mode for shutdown |
| Previous Message | Dmitriy Igrishin | 2010-12-15 21:47:10 | Re: hstores in pl/python |