Re: patch (for 9.1) string functions

From: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Merlin Moncure <mmoncure(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>
Subject: Re: patch (for 9.1) string functions
Date: 2010-08-24 06:32:47
Message-ID: AANLkTinUY-DnDSJxUrHDzJP14OTn7f=PtkMzDH65XFV7@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I applied the attached patch to HEAD. concat(), concat_ws(), left(),
right(), and reverse() are in it, but format() and sprintf() are not.
It's my understanding that we don't have consensus about the best syntax
for the formatting function. We can forget about RAISE. C-like printf
syntax is the next candidate, but we should consider about other ones
restarting with a clean slate.

Anyway, the newly added functions are useful for developers especially
migrated from other database products. Thank you.

On Mon, Aug 23, 2010 at 11:41 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> 2010/8/23 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> You should leave RAISE alone and just think about printf.
>
> ok - then we don't need modify proposed patch. "Format" function is
> enough for PL/pgSQL and other PL languages has own mutation of this
> functions. There are not barrier for implementation as custom
> function, so we can hold this function most simple.

--
Itagaki Takahiro

Attachment Content-Type Size
stringfunc-20100824.diff application/octet-stream 12.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2010-08-24 06:38:24 Re: patch (for 9.1) string functions
Previous Message Joe Conway 2010-08-24 06:24:41 Re: Typing Records