| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add unistd.h to c.h |
| Date: | 2011-03-11 16:57:18 |
| Message-ID: | AANLkTinT-E+W4En+LF53+ZH1-kez5_JjRhCbGgU4=iv3@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 11, 2011 at 11:53 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Heikki Linnakangas wrote:
>> On 11.03.2011 18:50, Bruce Momjian wrote:
>> > Twenty percent of our C files include unistd.h. Should we include
>> > unistd.h in c.h and remove mentions of unistd.h in files that include
>> > c.h?
>>
>> Why?
>
> Well, that is one less C include file in 151 C files, and just one
> additional line in c.h.
We could take it a little further and just make c.h include everything
that any file needs anywhere in the system. That would save even more
lines of code, but it has nothing else to recommend it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-03-11 16:59:22 | Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause, |
| Previous Message | Bruce Momjian | 2011-03-11 16:55:51 | Re: Add unistd.h to c.h |