| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: comments on type attributes broken in 9.1devel |
| Date: | 2010-10-19 11:23:20 |
| Message-ID: | AANLkTinSg-fLZgh_hhebvL6_z=1-rpXC8EZfAcZXOco9@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 19, 2010 at 1:46 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> The comment code refactoring c10575ff005c330d0475345621b7d381eb510c48
> broke comments on composite type attributes:
>
> COMMENT ON COLUMN foo.a is 'test';
> ERROR: 42809: "foo" is a composite type
> LOCATION: heap_openrv, heapam.c:1110
>
> This is because as the code was moved from CommentAttribute() to
> get_object_address_attribute(), the call to relation_openrv() became a
> heap_openrv(), which causes the above error.
>
> Please check it out.
Thanks. I changed that and added a regression test.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2010-10-19 11:23:38 | Re: max_wal_senders must die |
| Previous Message | Magnus Hagander | 2010-10-19 11:18:07 | Re: max_wal_senders must die |