Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts.
Date: 2010-12-17 16:34:48
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committerspgsql-hackers
On Fri, Dec 17, 2010 at 11:20 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Fri, Dec 17, 2010 at 9:52 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I imagine the reason for the original coding was to avoid a useless
>>> gettimeofday kernel call in the common case that there are no
>>> conflicting xacts to wait for.  Could we restore that behavior?
>> Something like the attached?
> I would just add the return-at-the-top.  Changing the loop logic is
> not necessary --- the loop test is cheap.

Hmm... that's a fine bit of hairsplitting, but OK.

Done that way, then.

Robert Haas
The Enterprise PostgreSQL Company

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-12-17 16:38:22
Subject: Re: proposal: FOREACH-IN-ARRAY (probably for 9.2?)
Previous:From: Peter EisentrautDate: 2010-12-17 16:28:12
Subject: Re: Unnecessary limit on max_standby_streaming_delay

pgsql-committers by date

Next:From: Andrew DunstanDate: 2010-12-17 17:00:52
Subject: pgsql: Backpatch plperl GNUmakefile fixes to allow building release8.2
Previous:From: Robert HaasDate: 2010-12-17 16:33:02
Subject: pgsql: Try to save a kernel call inResolveRecoveryConflictWithVirtualX

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group