| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Issues with dlgType |
| Date: | 2010-10-22 08:01:09 |
| Message-ID: | AANLkTin9hL5Cg5msZpwHG-nCqzEH9R2g53D8YS8dATOD@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Fri, Oct 22, 2010 at 12:29 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Hi,
>
> I've found quite a few bugs in the way we handle the dlgType dialog, and
> more to the point the Length and Precision textboxes. I use some time to
> work on this on my 11 hour plane trip, and I have this patch. The big
> issue I see is that it really contains a lot of changes. I'm not sure it
> is appropriate to apply it on 1.12.
>
> Actually, I want to apply it on 1.12. But I would like to know what
> others think about it.
Can you explain what the issues are please? Validating a patch against
unknown intent isn't easy.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2010-10-22 08:54:37 | Dynamic linking on Windows |
| Previous Message | Guillaume Lelarge | 2010-10-21 23:29:55 | Issues with dlgType |