Re: renaming contrib. (was multi-platform, multi-locale regression tests)

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Marti Raudsepp <marti(at)juffo(dot)org>, peter_e(at)gmx(dot)net, pgsql-hackers(at)postgresql(dot)org
Subject: Re: renaming contrib. (was multi-platform, multi-locale regression tests)
Date: 2010-11-11 00:51:06
Message-ID: AANLkTin8LFWVmL=KLsORWYUvjFO4abjy1++QX2rNXgZ1@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 10, 2010 at 7:01 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> The current name causes constant confusion. It's a significant misnomer, and
> leads people to distrust the code. There might be reasons not to change, but
> you should at least recognize why the suggestion is being made.

Is it your position that contrib code is as well-vetted as core code?

>>  (And no, don't you dare breathe a word about git making that
>> all automagically better.  I have enough back-patching experience with
>> git by now to be unimpressed; in fact, I notice that its rename-tracking
>> feature falls over entirely when trying to back-patch further than 8.3.
>> Apparently there's some hardwired limit on the number of files it can
>> cope with.)
>
> That's very sad. Did you file a bug?

It's intentional behavior. It gives up when there are too many
differences to avoid being slow.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2010-11-11 01:05:39 Re: renaming contrib. (was multi-platform, multi-locale regression tests)
Previous Message Robert Haas 2010-11-11 00:47:06 Re: multi-platform, multi-locale regression tests