| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: RecordTransactionCommit() and SharedInvalidationMessages |
| Date: | 2010-08-13 01:24:50 |
| Message-ID: | AANLkTin5uRUvAOgeMxn1EyPiYg-FJ5SAkkn5wNuReA21@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>>>> It appears to me that RecordTransactionCommit() only needs to WAL-log
>>>>> shared invalidation messages when wal_level is hot_standby, but I
>>>>> don't see a guard to prevent it from doing it in all cases.
[...]
>>> The fix looks pretty simple (see attached), although I don't have any
>>> clear idea how to test it.
>> Should use XLogStandbyInfoActive() macro, for the sake of consistency.
> And, RelcacheInitFileInval should be initialized with false just in case.
How about this?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| record_transaction_commmit-v2.patch | application/octet-stream | 941 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-08-13 01:28:35 | Re: including backend ID in relpath of temp rels - updated patch |
| Previous Message | Greg Smith | 2010-08-13 00:22:18 | Re: Patch to show individual statement latencies in pgbench output |