From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds |
Date: | 2011-01-09 17:07:39 |
Message-ID: | AANLkTin-3Dy8+COq9-UZGT-xqGFVDK-mRuNMpDZ++Mbp@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Sun, Jan 9, 2011 at 17:49, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Sun, Jan 9, 2011 at 17:31, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I'd like to protest this patch as misguided. AFAICS it is a *seriously*
>
>> Uh, we install the file on Unix, so we should do the same on Windows.
>
> Well, my idea of how to fix that would be the other way 'round.
Sure, then it's at least consistent...
>>> What we really need to be asking is why the pgAdmin folks think
>>> they should be including it.
>
>> It is required in order to pull kwlist.h,
>
> No, it is not required. What they should be doing is #define'ing
> PG_KEYWORD() in a way that ignores its second argument. See pg_dump's
> keywords.c for an example of safe usage.
Ahh, good point.
And yes, that seems to work for pgadmin. I'll commit a patch there as
soon as I've finished testing, at which point it won't be required
anymore.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-01-09 18:09:38 | pgsql: Use array_contains_nulls instead of ARR_HASNULL on user-supplied |
Previous Message | Tom Lane | 2011-01-09 16:49:00 | Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds |
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2011-01-09 17:55:49 | SSI and 2PC |
Previous Message | Tom Lane | 2011-01-09 16:49:00 | Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds |