Re: .gitignore files, take two

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: .gitignore files, take two
Date: 2010-09-21 12:12:33
Message-ID: AANLkTimy1gSiGe-52bY47NF04ZV-hnr_sEz1aLj3AHdb@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 21, 2010 at 13:12, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Sep 21, 2010 at 1:06 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> I suppose you already know my votes, but here they are again just in case.
>>> ...
>>> Centralize.
>>> ...
>>> All the build products in a normal build.
>>
>> I don't understand your preference for this together with a centralized
>> ignore file.  That will be completely unmaintainable IMNSHO.  A
>> centralized file would work all right if it's limited to the couple
>> dozen files that are currently listed in .cvsignore's, but I can't see
>> doing it that way if it has to list every executable and .so built
>> anywhere in the tree.  You'd get merge conflicts from
>> completely-unrelated patches, not to mention the fundamental
>> action-at-a-distance nastiness of a top-level file that knows about
>> everything going on in every part of the tree.
>
> Oh.  I was just figuring it would be pretty easy to regenerate from
> the output of git status.  You might have merge conflicts but they'll
> be trivial.  But then again, the effort of breaking up the output of
> git status into individual per-directory files is probably largely a
> one-time effort, so maybe it doesn't matter very much.

Breaking it up was quite trivial. Here's what I came up with after
building on my box. I'm sure there are some on other platforms showing
up, but this should be the majority.

I just realized it does not include contrib, but's that a mechanical
copy of the same thing.

So if we want to go with this way, i have the scripts/changes ready :)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Attachment Content-Type Size
gitignore.patch application/octet-stream 12.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Itagaki Takahiro 2010-09-21 12:38:03 Re: Basic JSON support
Previous Message Robert Haas 2010-09-21 11:55:27 Re: SHOW TABLES