Re: pgAdmin III commit: Default role support in server configs, quick conne

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Default role support in server configs, quick conne
Date: 2010-08-24 20:54:03
Message-ID: AANLkTimujFdmY5xOgXnzj5UhkNOSKp54G6vz0RWGdBfy@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

This patch seems to have sizing issue on Windows - basically there
isn't enough space on the dialogue for all the controls now.

It seems like we should move some onto an "Advanced" tab - but I'm
having a hard job persuading myself which should go (particularly as
we normally want a multi-line textbox on the first tab so it looks OK
when resized. The controls it makes most sense to move IMHO, are:

Rolename
DB restriction
Service
Restore env?

If we did that, I suppose the colour button could be resized vertically.

Thoughts?

On Wed, Jul 28, 2010 at 7:41 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
>
> Commit: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9af27f4c6978098e31343783994efe56f02b1707
>
> Log Message
> -----------
> Default role support in server configs, quick connect, backups and restore.
>
> Rolename parameter can be specified in each server's saved configuration.
> When a rolename is specified issue a SET role=<rolename> command after a
> successfull connection to the server. This allows using pgAdmin's gui to
> create/alter/delete objects in accordance with a security policy that
> forbids logging in directly as superuser, but instead specifies that you
> should log into an admin account and then SET ROLE to the superuser.
>
> It also makes it possible to specify the superuser account at backup
> and restore dialogs (pg_dump and pg_restore version >= 8.4 needed).
>
> Patch from Benedek László.
>
> Branch
> ------
> master
>
> Modified Files
> --------------
> pgadmin/db/pgConn.cpp                     |   24 ++++++++++-
> pgadmin/dlg/dlgRole.cpp                   |    2 +-
> pgadmin/dlg/dlgSelectConnection.cpp       |   41 +++++++++++++++++--
> pgadmin/dlg/dlgServer.cpp                 |    9 ++++-
> pgadmin/frm/frmBackup.cpp                 |   26 ++++++++++++
> pgadmin/frm/frmBackupGlobals.cpp          |   62 +++++++++++++++++++----------
> pgadmin/frm/frmBackupServer.cpp           |   39 +++++++++++++++---
> pgadmin/frm/frmMain.cpp                   |    1 +
> pgadmin/frm/frmRestore.cpp                |   27 ++++++++++++
> pgadmin/frm/frmStatus.cpp                 |    6 ++-
> pgadmin/include/db/pgConn.h               |    7 ++-
> pgadmin/include/dlg/dlgSelectConnection.h |    2 +-
> pgadmin/include/frm/frmBackupGlobals.h    |    1 +
> pgadmin/include/frm/frmBackupServer.h     |    1 +
> pgadmin/include/schema/pgServer.h         |    6 ++-
> pgadmin/pgAdmin3.cpp                      |   12 ++++--
> pgadmin/schema/pgRole.cpp                 |    1 +
> pgadmin/schema/pgServer.cpp               |   22 ++++++----
> pgadmin/ui/dlgSelectConnection.xrc        |   17 ++++++--
> pgadmin/ui/dlgServer.xrc                  |   16 ++++++-
> pgadmin/ui/frmBackup.xrc                  |   17 +++++++-
> pgadmin/ui/frmBackupGlobals.xrc           |   15 ++++++-
> pgadmin/ui/frmBackupServer.xrc            |   15 ++++++-
> pgadmin/ui/frmRestore.xrc                 |   16 +++++++-
> pgadmin/utils/sysSettings.cpp             |    1 +
> 25 files changed, 315 insertions(+), 71 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2010-08-24 21:03:21 Re: pgAdmin III commit: Default role support in server configs, quick conne
Previous Message Guillaume Lelarge 2010-08-24 20:41:13 Re: GSoC database modeler [Luis Ochoa]