| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, PgHacker <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: sepgsql contrib module |
| Date: | 2011-01-26 15:25:15 |
| Message-ID: | AANLkTims2=4kaONp0HdUCKn=EC67DpKHDD_C=q-eoRhB@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2011/1/25 KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>:
> (2011/01/26 12:23), KaiGai Kohei wrote:
>>>> Yikes. On further examination, exec_object_restorecon() is pretty
>>>> bogus. Surely you need some calls to quote_literal_cstr() in there
>>>> someplace.
>>>
>> Are you concerning about the object name being supplied to
>> selabel_lookup_raw() in exec_object_restorecon()?
>> I also think this quoting you suggested is reasonable.
>>
> How about the case when the object name only contains alphabet and
> numerical characters?
Oh, quote_literal_cstr() is the wrong function - these are
identifiers, not literals. So we should use quote_identifier().
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-26 15:27:57 | Re: systable_getnext_ordered |
| Previous Message | Kevin Grittner | 2011-01-26 15:22:12 | Re: SSI patch version 14 |