Re: [PERFORM] typoed column name, but postgres didn't grump

From: Merlin Moncure <mmoncure(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org, Jon Nelson <jnelson+pgsql(at)jamponi(dot)net>
Subject: Re: [PERFORM] typoed column name, but postgres didn't grump
Date: 2010-11-04 15:24:05
Message-ID: AANLkTimdEYcskXpSdiMDyK6R40G66T9SdM7JDUTvY=4h@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-performance

On Fri, Oct 29, 2010 at 4:12 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
>> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>>> I think if I had to pick a proposal, I'd say we should disable #2
>>>> for the specific case of casting a composite type to something
>>>> else.
>
>>> Well, then let's do that.  It's not the exact fix I'd pick, but
>>> it's clearly better than nothing, so I'm willing to sign on to it
>>> as a compromise position.
>
>> So, I'd rather scrap #2 entirely; but if that really would break
>> much working code, +1 for ignoring it when it would cast a composite
>> to something else.
>
> Well, assuming for the sake of argument that we have consensus on fixing
> it like that, is this something we should just do in HEAD, or should we
> back-patch into 8.4 and 9.0?  We'll be hearing about it nigh
> indefinitely if we don't, but on the other hand this isn't the kind of
> thing we like to change in released branches.

Trying to understand real world cases that this would break...would
the following now fail w/o explicit cast?

create type x as (a int, b int);
select f((1,2));

merlin

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Kevin Grittner 2010-11-04 15:35:08 Re: [PERFORM] typoed column name, but postgres didn't grump
Previous Message Dimitri Fontaine 2010-11-04 08:18:35 Re: BUG #5740: contrib/spi/moddatetime.c doesn't work with timezones.

Browse pgsql-performance by date

  From Date Subject
Next Message Kevin Grittner 2010-11-04 15:35:08 Re: [PERFORM] typoed column name, but postgres didn't grump
Previous Message Maciek Sakrejda 2010-11-04 15:13:03 Re: Simple (hopefully) throughput question?