| From: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add ENCODING option to COPY |
| Date: | 2011-01-31 15:07:19 |
| Message-ID: | AANLkTim_9rZndfqneZuuaSVUq-Vge6z8MfYzQ9EaEky7@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2011/1/31 Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>:
> 2011/1/31 Robert Haas <robertmhaas(at)gmail(dot)com>:
>> On Tue, Jan 25, 2011 at 10:24 AM, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> wrote:
>>> I'll check the code more if we have better alternatives.
>>
>> Where are we with this?
>
> I'll post another version today.
Here's the patch.
Finally I concluded the concern Itagaki-san raised can be solved by
adding code that restores client_encoding in copy_in_error_callback. I
tested some encoding mismatch cases with this patch and saw
appropriate messages in NLS environment.
Regards,
--
Hitoshi Harada
| Attachment | Content-Type | Size |
|---|---|---|
| copy_encoding.v2.patch | application/octet-stream | 8.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2011-01-31 15:10:43 | Re: FPI |
| Previous Message | Simon Riggs | 2011-01-31 15:06:56 | Re: Error code for "terminating connection due to conflict with recovery" |