| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: memory leak in libxml2 - fix |
| Date: | 2010-11-26 10:42:26 |
| Message-ID: | AANLkTimQM0=R17fOzh3REPxp+c=ura41mE65aLkS-Er+@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2010/11/26 Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>:
> On Fri, Nov 26, 2010 at 17:59, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> our customer showed a very significant memory leak in xml2.
>> It never release a memory allocated for context and doctree.
>
> Why did you change doctree and ctxt to global variables?
> I'm not sure why /* xmlFreeDoc(doctree); */ is commented out
> at the end of pgxml_xpath(), but is it enough to enable the code?
>
I am thinking, so you must not to call xmlFreeDoc(doctree) early.
Probably xmlXPathCastToXXX reading a doctree.
xmlXPathFreeContext(ctxt); xmlFreeDoc(doctree); are called now only
when function doesn't return a value.
Regards
Pavel Stehule
> --
> Itagaki Takahiro
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2010-11-26 11:30:37 | Re: pg_execute_from_file review |
| Previous Message | Pavel Stehule | 2010-11-26 10:37:42 | ToDo: enhanced diagnostic for plpgsql |