Re: Policy decisions and cosmetic issues remaining for the git conversion

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Policy decisions and cosmetic issues remaining for the git conversion
Date: 2010-09-13 18:08:07
Message-ID: AANLkTimLFo7aM5K_nyiqZrvbUJNdUMbEzfSwc7Xkvj47@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 13, 2010 at 1:21 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Mon, Sep 13, 2010 at 12:50 PM, Alvaro Herrera
>> <alvherre(at)commandprompt(dot)com> wrote:
>>> +1 on both -- fixing the broken tags, and creating the missing tags,
>>> particularly since you already seem to have found out the necessary
>>> dates for the missing tags.
>
>> +1 from me, too.  I don't agree with statements upthread that this
>> will be "easier" to do in git.  I think we should fix the CVS history.
>>  The git conversion is a one-time event.  Once it's done, history is
>> set in stone.  We don't want to set the wrong thing in stone.
>
> Well, the other side of that argument is that changing these things in
> the CVS repository will be overwriting the available evidence, in case
> any questions come up later.  On the git side, applying the tag to the
> appropriate commit is an easy --- and easily changeable --- thing, isn't
> it?

You can apply the tag to any commit that you want easily enough, but
you can't change even the least detail of the commit contents. So if
it turns out that there's no commit that exactly matches the desired
tag contents, then things get sticky. That's why we need to make sure
that the reconstructed series of commits exactly matches what really
happened as closely as possible the first time through. If it
doesn't, we're pretty hosed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-09-13 18:17:39 Re: Policy decisions and cosmetic issues remaining for the git conversion
Previous Message Heikki Linnakangas 2010-09-13 18:01:49 Re: Interruptible sleeps (was Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!)