Re: [RRR] top-level DML under CTEs

From: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
To: Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>
Cc: pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: [RRR] top-level DML under CTEs
Date: 2010-10-03 13:47:28
Message-ID: AANLkTimG=XftAG_WV8SuT9YNJQHmzFAys0ZyYm5we9CR@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-rrreviewers

2010/10/1 Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>:
> 2010/9/30 Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>:
>> On 2010-09-23 9:12 AM +0300, Hitoshi Harada wrote:
>>>
>>> Since the transformation of
>>> WITH clause to cheat postgres is in the parser stage currently, I
>>> wonder if this should be done in the rewriter or the planner stage.
>>
>> It's been about a week now.  Should we expect a new patch soon?
>>
>>
>
> Yep, I'm working it now. You'll see the conclusion in a day or so.

...and attached is the latest patch. It contains LIMIT etc. bug of
INSERT fixes and I confirmed the barrule case correctly in this
version.

> =# CREATE RULE barrule AS ON UPDATE TO bar DO INSTEAD
> -# WITH RECURSIVE t AS (SELECT -1)
> -# INSERT INTO bar
> -# WITH t AS (SELECT 1)
> -# VALUES((SELECT * FROM t));

Regards,

--
Hitoshi Harada

Attachment Content-Type Size
toplevel-dml-cte.20101003.diff application/octet-stream 20.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2010-10-03 13:53:34 Re: ISN patch that applies cleanly with git apply
Previous Message Hitoshi Harada 2010-10-03 13:42:10 Re: INSERT ... VALUES... with ORDER BY / LIMIT

Browse pgsql-rrreviewers by date

  From Date Subject
Next Message Hitoshi Harada 2010-10-03 14:06:25 Re: wip: functions median and percentile
Previous Message ๏̯͡๏ Guido Barosio 2010-10-02 00:26:16 Re: Patch reviewers