Re: [PATCH] "could not reattach to shared memory" on Windows

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Etienne Dube <etdube(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] "could not reattach to shared memory" on Windows
Date: 2010-07-23 13:55:15
Message-ID: AANLkTim128xVBMreFFOxAw04dA5akoS3BRuZaU8rAJbY@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 20, 2010 at 17:31, Etienne Dube <etdube(at)gmail(dot)com> wrote:
> On 09/02/2010 4:09 PM, Etienne Dube wrote:
>>
>> Magnus Hagander wrote:
>>>
>>> IIRC, we've had zero reports on whether the patch worked at all on 8.2
>>> in an environment where the problem actually existed. So yes, some
>>> testing and feedback would be much apprecaited.
>>>
>>> //Magnus
>>
>> Thanks for your quick reply.
>> We upgraded to Service Pack 2 and it solved the problem. Nevertheless,
>> I'll try to reproduce the issue under a Win2008 SP1 VM to see whether the
>> patch makes a difference. 8.2.x win32 binaries are built using MinGW right?
>>
>> Etienne
>>
>>
>
>
> The "could not reattach to shared memory" bug came back to bite us, this
> time on a production machine running Windows Server 2008 R2 x64. I manually
> applied the patch against the 8.2.17 sources and installed the build on a
> test server. It has been running for two days without any issue. We'll see
> after a while if the patch actually fixes the problem (it seems to happen
> only after the postgres service has been up and running for some time) but
> in case you want to include this fix in a future 8.2.18 release, I've
> attached the new patch to apply against the REL8_2_STABLE branch.

Yes, I think it's time to backpatch this to 8.2 - it has worked very
well on 8.3 and 8.4, and we've had a couple of good reports on 8.2 by
now. So I've done that, so it should be in the next 8.2 version.

In fact, there was a small bug in the patch that broke all non-win32
platforms, so I fixed that while at it :-)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-07-23 14:11:36 Re: [HACKERS] Trouble with COPY IN
Previous Message Kevin Grittner 2010-07-23 13:51:51 Re: Patch for 9.1: initdb -C option