From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted. |
Date: | 2010-07-02 20:18:54 |
Message-ID: | AANLkTilaob_KNpu3tLZRoJeoxSkweudhgErE2u33LpWR@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Jul 2, 2010 at 12:38 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Jul 2, 2010 at 11:07 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Fri, Jul 2, 2010 at 10:21 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>>>>>> This appears to have broken MinGW and Cygwin builds on the buildfarm.
>>>>>
>>>>> Well, that's not awesome. IM-ing with Magnus now. I'm wondering if
>>>>> this is a link-ordering problem of some kind.
>>>>
>>>> Possibly an #ifndef FRONTEND will fix it.
>>>
>>> What's failing to link is postgres.exe
>>
>> I suspect that moving copydir.c into the backend will fix this, but I
>> don't have an appropriate build environment to test. Can someone
>> please test the attached patch?
>
> Andrew confirms that this works on mingw, so I'm going to go ahead and
> check it in and see what happens.
hamerkop [Windows Server 2008 R2 (64bit) Visual C++ 2005 AMD64] is not
happy with this.
http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=hamerkop&dt=2010-07-02%2018:45:44
I don't really understand most of the log messages, but the problem
seems to be here (some garbage removed for clarity):
LINK : fatal error LNK1104: '.\Release\postgres\src_port_copydir.obj'
LIB : fatal error LNK1181: '.\Release\libpgport\copydir.obj'
What doesn't make sense about that is that that file should not have
existed in the snapshot hamerkop ran against.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-07-02 20:36:49 | pgsql: Remove hstore % text[] operator; use slice() function instead. |
Previous Message | Robert Haas | 2010-07-02 17:03:38 | pgsql: Move copydir.c from src/port to src/backend/storage/file The |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-07-02 20:20:46 | Re: Keepalive for max_standby_delay |
Previous Message | Tom Lane | 2010-07-02 20:11:35 | Re: Keepalive for max_standby_delay |