From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: .gitignore files, take two |
Date: | 2010-09-21 18:10:54 |
Message-ID: | AANLkTikzbUNWCONfvk5_pC62JSWNY9UrNkA-CdhxRHqN@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Sep 21, 2010 at 19:46, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Tue, Sep 21, 2010 at 17:27, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Why does this entry have a / when none of the rest do? Shouldn't
>>> we be consistent about that?
>
>> We should. I've removed it.
>
>> The difference is that "zic" matches zic in any subdirectory and
>> "/zic" matches just in the top dir. But we're not having any other
>> thing called zic further down - it's really only a potential problem
>> at the top level.
>
> Hmm. In leaf subdirectories it doesn't matter of course, but I'm
> worried about .gitignore files in non-leaf subdirectories accidentally
> excluding files further down the tree. Wouldn't it be better to
> standardize on always using the slash, rather than not using it?
Yeah, good point. I just took the path of least resistance :-) I'll
update with that before commit.
Have we decided to do this? If so, I'll start backpatching it...
>> Btw, what's the "stamp-h" file? Should that be excluded globally?
>
> I'd say no, there's only one or two instances.
Ok. Since I don't know what it is, I didn't know if it's likely to pop
up anywhere else under different circumstances.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-09-21 18:16:10 | Re: moving development branch activity to new git repo |
Previous Message | Tom Lane | 2010-09-21 18:10:48 | Re: Git conversion status |