From: | Boxuan Zhai <bxzhai2010(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Greg Smith <greg(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: ask for review of MERGE |
Date: | 2010-09-29 13:29:09 |
Message-ID: | AANLkTiky7H-faSMPx-=nTxH6HoG=U3t8nQR3Ek=XC+Am@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Sep 29, 2010 at 9:16 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Sep 29, 2010 at 2:44 AM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
> > One compiler warning I noticed that needs to get resolved:
> >
> > src/backend/commands/explain.c:
> >
> > explain.c: In function ‘ExplainMergeActions’:
> > explain.c:1528: warning: comparison of distinct pointer types lacks a
> cast
> >
> > That is complaining about this section:
> >
> > if (mt_planstate->operation != CMD_MERGE ||
> > mt_planstate->mt_mergeActPstates == NIL)
> > return;
> >
> > So presumably that comparison with NIL needs a cast. Once I get more
> > familiar with the code I'll fix that myself if Boxuan doesn't offer a
> > suggestion first.
>
> Possibly NULL was meant instead of NIL. NIL is specifically for a List.
>
>
Yes, it should be NULL instead of NIL.
At first, I designed this filed as a List. But I changed it into an array in
the last editions. This is why I have an unmatched assignment here. Sorry
for that.
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise Postgres Company
>
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2010-09-29 13:45:15 | Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session |
Previous Message | Robert Haas | 2010-09-29 13:16:38 | Re: ask for review of MERGE |