| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Quan Zongliang <quanzongliang(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, David Fetter <david(at)fetter(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fw: patch for pg_ctl.c to add windows service start-type |
| Date: | 2010-08-20 09:21:18 |
| Message-ID: | AANLkTikxj-1ZyZd+32PiGPWQrh7zN-uQtekmXDcWEp+O@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 20, 2010 at 01:01, Quan Zongliang <quanzongliang(at)gmail(dot)com> wrote:
> Because Windows's CreateService has serial start-type:
> SERVICE_AUTO_START
> SERVICE_BOOT_START
> SERVICE_DEMAND_START
> SERVICE_DISABLED
> SERVICE_SYSTEM_START
>
> Although all of them are not useful for pg service.
> I think it is better to use enum.
I don't see us ever using anything other than auto or demand. The
others aren't for "regular services", except for "disabled". And
adding a disabled service makes no sense :-) So I'm with Alvaro, I
think it's a good idea to simplify that.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitriy Igrishin | 2010-08-20 10:13:45 | SQLSTATE of notice PGresult |
| Previous Message | Marko Tiikkaja | 2010-08-20 09:09:40 | Re: Avoiding deadlocks ... |