| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list. |
| Date: | 2011-03-11 18:59:40 |
| Message-ID: | AANLkTikusYFg++-r9uu=2H7FWuHMP-o3DU-86FacAbtG@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Mar 8, 2011 at 4:44 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Add missing keywords to gram.y's unreserved_keywords list.
>
> We really need an automated check for this ... and did VALIDATE really
> need to become a keyword at all, rather than picking some other syntax
> using existing keywords?
I think we ought to try to do something about this, so that VALIDATE
doesn't need to become a keyword.
How about instead of VALIDATE CONSTRAINT we simply write ALTER
CONSTRAINT ... VALID? (Patch attached, passes make check.)
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| alter-constraint-valid.patch | application/octet-stream | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2011-03-11 19:29:38 | Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list. |
| Previous Message | Tom Lane | 2011-03-11 18:20:37 | pgsql: Create an explicit concept of collations that work for any encod |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2011-03-11 19:29:38 | Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list. |
| Previous Message | Greg Stark | 2011-03-11 18:21:20 | Re: Fwd: index corruption in PG 8.3.13 |