From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_primary_conninfo |
Date: | 2010-12-28 13:39:37 |
Message-ID: | AANLkTiku+F8wdA_s_fmCcb8LR1SubOQHYHhXLY8fdenz@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Dec 28, 2010 at 14:38, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Dec 28, 2010 at 8:31 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Attached patch implements a function called pg_primary_conninfo() that
>> returns, well, the primary_conninfo used on the standby when in
>> streaming replication mode (otherwise NULL).
>
> +1. Let's make sure to explicitly document what this function returns
> when recovery was previous in progress, but we are now in normal
> running.
Oh, didn't think of that scenario.
Is that intended behaviour though? I tend to think that it is (since
you can check with pg_is_in_recovery) as long as it's documented, but
might it make more sense to have it return NULL in this case?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | tv | 2010-12-28 13:41:24 | Re: estimating # of distinct values |
Previous Message | Robert Haas | 2010-12-28 13:39:20 | Re: Function for dealing with xlog data |