Re: pgsql: Properly lowercase identifiers, uppercase keywords, in doc

From: Thom Brown <thom(at)linux(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Properly lowercase identifiers, uppercase keywords, in doc
Date: 2010-08-11 22:19:26
Message-ID: AANLkTikkA1qOpWarSXuUfHgCCnbyQKmj=X23sYWv9Ur9@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 11 August 2010 23:04, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
>> Log Message:
>> -----------
>> Properly lowercase identifiers, uppercase keywords, in doc examples
>
> Bruce, did you do that with a blind sed script?  You totally destroyed
> the point of these examples.  Kindly revert.
>

Whilst that change definitely needs reverting, I noticed the following
doesn't read well:

"Additionally, comments can occur in SQL input. They are not tokens,
they are effectively equivalent to whitespace.

For example, the following is (syntactically) valid SQL input:"

You'd expect an example with comments in after reading that, but there isn't.

Maybe that "Additionally..." bit should be moved beneath the "This is
a sequence..." paragraph?

--
Thom Brown
Registered Linux user: #516935

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-08-12 00:40:59 pgsql: Extend psql's \e and \ef commands so that a line number can be
Previous Message Tom Lane 2010-08-11 22:04:07 Re: pgsql: Properly lowercase identifiers, uppercase keywords, in doc