Re: [COMMITTERS] pgsql: pgindent run for 9.0, second run

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: pgindent run for 9.0, second run
Date: 2010-07-20 16:13:06
Message-ID: AANLkTikk+0tA7zH0Er-4BHgQUSqZqpgrXxYPSuB9q8YY@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Jul 20, 2010 at 12:01 PM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>> I despaired of this repo being anything like reliable months ago.
>> AFAIK it is using a known to be broken version of fromcvs.
>
> Could we have it pull (using git) from the repo you have working
> correctly?  (Or would that be too Rube Goldbergesque?)

It would result in a massive merge commit and the duplication of the
entire history. The correct solution is probably to (a) install
Andrew's fixed version of the import tool on the server and (b) rewind
the history on the server so it reimports all the subsequent commits.
Sometimes doing only (b) is sufficient to correct the problem, since
the tool seems rather sensitive to ephemeral states of the
respository.

Unfortunately, (a) has not happened. Magnus seems to feel that Andrew
has not provided sufficient details about which version he should be
running and whether it will likely break anything, and I gather that
Andrew feels otherwise. Figuring out who is right and who is wrong
and what to do about it is above my pay grade, but it would be really
nice if someone could get this straightened out.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2010-07-20 16:20:42 Re: [COMMITTERS] pgsql: pgindent run for 9.0, second run
Previous Message Kevin Grittner 2010-07-20 16:01:07 Re: [COMMITTERS] pgsql: pgindent run for 9.0, second run

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-07-20 16:20:42 Re: [COMMITTERS] pgsql: pgindent run for 9.0, second run
Previous Message Mark Wong 2010-07-20 16:08:51 Re: Explicit psqlrc