Re: Re: [COMMITTERS] pgsql: Make a hard state change from catchup to streaming mode.

On Fri, Feb 18, 2011 at 10:56 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> We need a hard state change at one particular point to avoid sync rep
> requestors from hanging for hours when the standby is connected but a
> long way from being caught up.

That's a matter of opinion. I think there are a number of people here
who would say that what you need is a good way to know when you've
caught up, and that you shouldn't enable sync rep until that happens.
What you're proposing would be useful too, if it didn't break other
cases, but it does. This is precisely why it's a bad idea for us to
be trying to do this kind of engineering at the very last minute.

> This was a part of my sync rep patch that it was easier to break out and
> commit early. There has never been any comment or objection to this
> concept and the same feature has existed in my patches for months.

You posted the latest version of your sync rep patch on January 15th,
after months of inactivity. Heikki reviewed it on the 21st, and there
it sat un-updated for three weeks. If your expectation is that any
portion of that patch to which nobody specifically objected is fair
game to commit without further discussion, I don't think that's the
way it works around here.

Post your patches and we'll review them.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company