Re: pgAdmin III commit: Somehow forgot to commit this.

From: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Thom Brown <thom(at)linux(dot)com>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Somehow forgot to commit this.
Date: 2011-02-16 13:21:09
Message-ID: AANLkTikh3twOz827D_VyjO=ic5V6X8HJX6cp7WDry9dd@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

uh, what about the patch I sent you last night,
patch_with_ogl.patch.gz? It integrated OGL into our tree.

By the way, this shouldn't have been changed, and has been changed
back in that patch:

//Create SQL editor notebook
sqlNotebook = new ctlAuiNotebook(this, CTL_NTBKCENTER,
wxDefaultPosition, wxDefaultSize, wxAUI_NB_TOP | wxAUI_NB_TAB_SPLIT |
wxAUI_NB_TAB_MOVE | wxAUI_NB_SCROLL_BUTTONS |
wxAUI_NB_WINDOWLIST_BUTTON);
@@ -994,7 +994,7 @@ void frmQuery::OnChangeConnection(wxCommandEvent &ev)
pgConn *newconn = dlg.CreateConn(applicationname, createdNewConn);
if (newconn && createdNewConn)
{
- cbConnection->Insert(newconn->GetName(),
CreateBitmap(GetServerColour(newconn)), sel, (void *)newconn);
+ cbConnection->Insert(newconn->GetName(),
CreateBitmap(GetServerColour(newconn)), sel, (wxClientData *)newconn);

--
Regards,
Peter Geoghegan

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2011-02-16 13:28:15 pgAdmin III commit: Revert change to cast, per Peter.
Previous Message Dave Page 2011-02-16 13:07:43 Re: pgAdmin III commit: Somehow forgot to commit this.