From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Adjust basebackup.c to suppress compiler warnings. |
Date: | 2011-01-11 19:06:39 |
Message-ID: | AANLkTikVusK8Nf5MWxjD-w0zVUPhtwxw5jHEwCud0X2m@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Tue, Jan 11, 2011 at 19:42, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Adjust basebackup.c to suppress compiler warnings.
>
> Some versions of gcc complain about "variable `tablespaces' might be
> clobbered by `longjmp' or `vfork'" with the original coding. Fix by
> moving the PG_TRY block into a separate subroutine.
I noticed you didn't create a function prototype at the top of the
file for this function. Was that intentional, or missed? If it was
intentional, can you give me a quick lesson in when it should be done
and whe nit shouldn't? :-)
//Magnus
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e6dce4e439e1d271dad9a95bc4b94147be2fc39a
>
> Modified Files
> --------------
> src/backend/replication/basebackup.c | 54 ++++++++++++++++++++-------------
> 1 files changed, 33 insertions(+), 21 deletions(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers
>
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-01-11 19:44:04 | Re: pgsql: Adjust basebackup.c to suppress compiler warnings. |
Previous Message | Tom Lane | 2011-01-11 18:42:12 | pgsql: Adjust basebackup.c to suppress compiler warnings. |