Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Chris Travers <chris(at)metatrontech(dot)com>, Cristian Bittel <cbittel(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session
Date: 2010-08-24 19:39:13
Message-ID: AANLkTikROhwVsyG9VBD_8-zx2PBoi4jLK7GkJR3FXBU5@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Aug 24, 2010 at 3:10 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Tue, Aug 24, 2010 at 15:58, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>>> Robert Haas wrote:
>>>> Yeah, that seems very plausible, although exactly how to verify I don't know.
>>
>>> And here is confirmation from the Microsoft web site:
>>
>>>       In some instances, calling GetExitCode() against the failed process
>>>       indicates the following exit code:
>>>       128L ERROR_WAIT_NO_CHILDREN - There are no child processes to wait for.
>>
>> Given the existence of the deadman switch mechanism (which I hadn't
>> remembered when this thread started), I'm coming around to the idea that
>> we could just treat exit(128) as nonfatal on Windows.  If for some
>> reason the child hadn't died instantly at startup, the deadman switch
>> would distinguish that from the case described here.
>
> Just because I had written it before you posted that, here's how the
> win32-specific-set-a-flag-when-we're-in-control thing would look. But
> if we're convinced that just ignoring error 128 is safe, then that's
> obviously a simpler patch..

So, if we do this, what will happen to the client connection that was
due to be handled by the backend being spawned? Is this going to lead
to extra fds accumulating or any such thing?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Magnus Hagander 2010-08-24 19:40:59 Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session
Previous Message Magnus Hagander 2010-08-24 19:16:29 Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-08-24 19:40:59 Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session
Previous Message Marko Tiikkaja 2010-08-24 19:20:07 Re: Backups from the standby (Incrementally Updated Backups), open item