Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.
Date: 2010-09-27 01:03:24
Message-ID: AANLkTikPEBL4T7PsS809w+VY4Wup0HAxW6y55fWbxFPx@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sun, Sep 26, 2010 at 8:24 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Sun, Sep 26, 2010 at 4:38 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Hah, I have a plan.  Let's just run git log for "master..RELx_y_STABLE"
>>> for each branch, rather than all the way back.
>
>> This doesn't seem more reliable to me in any way.  Looking at the
>> actual commit history must surely be more reliable than assuming you
>> know what it is.  I think what you should be doing is using git log
>> --decorate and extracting the information from that as you go by.
>
> I looked at doing that but it didn't seem like an improvement.  Take
> a look at the new version and see what you think.

I'm not really sure. I suppose I'll have to play with it for a while
to really form a clear opinion. Clearly, knowing which minor releases
a commit is in is a major improvement, but the whole thing is so
heavily re-engineered from my original version that I'm not really
sure whether there's anything else that I care about that got broken
in the process. In particular, I'm wondering to what extent we're
baking in branch management conventions from which we may wish to
depart at some point in the future.

I maintain that if someone else whacked around one of your commits the
way you whacked this around, you'd bite their head off.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-09-27 01:09:35 Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.
Previous Message Tom Lane 2010-09-27 00:24:21 Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-09-27 01:08:12 Re: recovery.conf location
Previous Message Tom Lane 2010-09-27 00:56:53 Re: recovery.conf location