| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Speed up conversion of signed integers to C strings. |
| Date: | 2010-11-20 06:10:31 |
| Message-ID: | AANLkTikFFW3iqzh_Hz1y7pGr1X+xUszYj55H_NULJF_2@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Nov 19, 2010 at 11:47 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>>> Speed up conversion of signed integers to C strings.
>
>> This patch breaks the build here:
>
> ... and while I'm looking at it, the added int8 regression test cases
> definitely merit a WTF. They aren't testing what I would expect.
> What they are testing is platform-specific behavior of excessive
> shifting, which is why some of the buildfarm members are pink.
Ugh. I made an attempt at a fix to both of these issues, but I'm not
totally sure I got it right, and I'm too tired to stay up any later to
see what happens. I'll check the BF in the morning.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2010-11-20 10:23:27 | Re: pgsql: Speed up conversion of signed integers to C strings. |
| Previous Message | Robert Haas | 2010-11-20 06:09:35 | pgsql: Attempt to fix breakage caused by signed integer conversion patc |