From: | Jasmin Dizdarevic <jasmin(dot)dizdarevic(at)gmail(dot)com> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers(at)postgresql(dot)org, Dave Page <dpage(at)pgadmin(dot)org> |
Subject: | Re: Info on non supported Features |
Date: | 2011-01-10 10:07:37 |
Message-ID: | AANLkTikAPD3NSzzLUptbST9-bEezvfc7JqH9mAWgciWM@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Sure, it's possible, but then you have take care of each control
individually. Setting a text in a combobx and checkbox is quiet different.
I think this change is acceptable, because the label control is kept. Only
the control, which is also not accessible by a tab is hidden.
Radio buttons could not be covered this way. The items would have to be
disabled manually.
Resizing should not be a problem (in my test there were no problems),
because the control is replaced through wxSizer::Replace(). So it's kept in
the "grid flow".
2011/1/10 Guillaume Lelarge <guillaume(at)lelarge(dot)info>
> Le 10/01/2011 10:53, Dave Page a écrit :
> > On Mon, Jan 10, 2011 at 1:22 AM, Jasmin Dizdarevic
> > <jasmin(dot)dizdarevic(at)gmail(dot)com> wrote:
> >> Hi Guys,
> >> as I started working on email notification Dave told me, that I've to
> >> disable all email notification relevant GUI elements, if the required
> >> pgAgent version is not installed.
> >> I did that of course, but I thought why we should not tell the user, why
> a
> >> control is disabled.
> >> My idea is not to disable the control, but hide it and place an
> explaining
> >> text on it's position. In code we know which version is required because
> of
> >> the call pgConn::BackendMinimumVersion(major, minor).
> >> I've extended this method to
> pgConn::BackendMinimumVersion(major,wxControl*
> >> control) and every time this is called, the desired control will be
> hidden
> >> and a wxStaticText control will be added.
> >> The text is for example: Supported in PostgreSQL %i.%i, major, minor
> >> => Supported in PostgreSQL 9.1. See also the attached screenshots.
> >> I know this is not applicable in all situations, but it's a useful
> >> information.
> >> What you think about it? Shall I finalize this feature?
> >
> > Changing the type of control doesn't seem like a good idea. It can
> > make the dialogue look different depending on the server that is
> > connected, which may confuse the user. If you simply set the text in
> > the existing control, I think that would be acceptable. Of course, it
> > wouldn't work for radio buttons/checkboxes, but I think that's a small
> > price to pay.
> >
>
> I don't see why it couldn't work for radio buttons and checkboxes. They
> also have text. We dont' use that now, but it could be use for this.
>
>
> --
> Guillaume
> http://www.postgresql.fr
> http://dalibo.com
>
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2011-01-10 10:16:57 | Re: Info on non supported Features |
Previous Message | Dave Page | 2011-01-10 10:01:29 | Re: Info on non supported Features |