Re: ask for review of MERGE

On 23 September 2010 11:31, Boxuan Zhai <bxzhai2010(at)gmail(dot)com> wrote:
> Dear All,
> I have just generate a new patch of MERGE command.
> One main change in this edition is the removal of RASIE ERROR action from
> MEREG, because its semantics is not well defined yet.
> I also rewrote the regress test file merge.sql, to make it consistent with
> the examples I used in my wiki page.
> Some little (error and warning) bugs are fixed.
> In this patch, all the main features of MERGE (sublinks, explain, rule and
> trigger, inheritance) are not changed. And so is the DO NOTHING action.
> I do wish the MERGE command can be added into psql 9.1. And I wonder what
> improvement should be made on current edition.
> Could you please have a review on this patch, if you have time and interest?
> Your feedback will be highly appreciated.
> Thanks
>
> Yours Boxuan

A few corrections:

in src/backend/executor/nodeModifyTable.c:
s/excute/execute/
s/orignial/original/

in src/backend/optimizer/plan/planner.c
s/expreesions/expressions/
s/So,we/So, we/
s/comand/command/
s/fileds/fields/

in src/backend/optimizer/prep/preptlist.c:
s/aggresive/aggressive/

in src/backend/optimizer/util/var.c
s/targe/target/ -- this appears twice
s/sourse/source/

in src/backend/parser/analyze.c
s/takend/taken/
s/relaion/relation/
s/targe/target/ -- this appears twice
s/consitency/consistency/
s/commond/command/
s/seperate/separate/

in src/backend/rewrite/rewriteHandler.c
s/acton/action/

in src/include/nodes/execnodes.h
s/meger/merge/

in src/include/nodes/parsenodes.h
s/proecess/process/
s/allwo/allow/
s/elments/elements/

in src/test/regress/expected/merge.out
s/qulifications/qualifications/ -- this appears twice
s/suceeds/succeeds/ -- this appears twice

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935