Skip site navigation (1) Skip section navigation (2)

Re: git: uh-oh

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Haggerty <mhagger(at)alum(dot)mit(dot)edu>, Max Bowsher <maxb(at)f2s(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: git: uh-oh
Date: 2010-09-06 07:51:54
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On Mon, Sep 6, 2010 at 06:09, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Haggerty <mhagger(at)alum(dot)mit(dot)edu> writes:
>> Tom Lane wrote:
>>> I suspect what it's doing is attributing the branch creation to the user
>>> who makes the first commit on the branch for that file.  In general I'd
>>> expect that to give a reasonable result --- better than choosing a
>>> guaranteed-to-be-wrong constant value anyway ;-)
>> On the contrary, I prefer an obvious indication of "I don't know" to a
>> value that might appear to be authoritative but is really just a guess.
>>  It could be that one user copied the file verbatim to the branch and a
>> second user changed the file as part of an unrelated change.
> Hm, I see.
>> The "default default" value for these commits is "cvs2svn" (in your case
>> "cvs2git would probably be more appropriate), which I like because it
>> makes it clearer than "pgsql" that the commit was generated as part of a
>> conversion.
> If we can set it to a value different from any actual committer name,
> that would be a good thing to do.

I intentionally picked the "pgsql" user because AFAIK that's what
we've been previously using for "commits that aren't commits". I
figured the repository would be cleaner with just one such pseudo-user
rather than two. But it's a trivial change - it just needs a name and
an email address (which doesn't have to actually work, of course)

 Magnus Hagander

In response to


pgsql-hackers by date

Next:From: Magnus HaganderDate: 2010-09-06 07:57:20
Subject: Re: Windows Tools
Previous:From: Magnus HaganderDate: 2010-09-06 07:50:02
Subject: Re: git: uh-oh

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group