Re: missing history for pg_exec_query_string()

From: Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
To: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: missing history for pg_exec_query_string()
Date: 2011-03-23 23:50:45
Message-ID: AANLkTik3ej+wYOHuZ+LiH9WqHppM+QBvp6qvmg1yHDrw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2011/3/23 Jaime Casanova <jaime(at)2ndquadrant(dot)com>:
> Hi,
>
> I'm looking for the history of pg_exec_query_string() and found that
> it dissapear in 7.4, so i tried to look at "git log" to find out if it
> was renamed or removed completely and found only this 3 commits:
> http://git.postgresql.org/gitweb?p=postgresql.git&a=search&h=cd48aa0e9636c6225d34f366a9d71e7fc118c9f3&st=commit&s=pg_exec_query_string,
> and none of them removes or renames it...
>
> i'm pretty sure exec_simple_query() is what we used to call
> pg_exec_query_string() but i had to look for functions with similar
> names and then compare the code, not very elegant :(
>
> any idea what happens to this part of the history?

This :
git log --pretty=oneline -S'pg_exec_query_string' origin/REL7_4_STABLE
git show de28dc9a04c4df5d711815b7a518501b43535a26

give me the answer :

commit de28dc9a04c4df5d711815b7a518501b43535a26
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Date: Fri May 2 20:54:36 2003 +0000

Portal and memory management infrastructure for extended query protocol.
Both plannable queries and utility commands are now always executed
within Portals, which have been revamped so that they can handle the
load (they used to be good only for single SELECT queries). Restructure
code to push command-completion-tag selection logic out of postgres.c,
so that it won't have to be duplicated between simple and extended queries.
initdb forced due to addition of a field to Query nodes.

wonderful git :)

>
> --
> Jaime Casanova         www.2ndQuadrant.com
> Professional PostgreSQL: Soporte y capacitación de PostgreSQL
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

--
Cédric Villemain               2ndQuadrant
http://2ndQuadrant.fr/     PostgreSQL : Expertise, Formation et Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Hammond 2011-03-24 00:03:09 Query to generate CREATE INDEX statement from
Previous Message Jaime Casanova 2011-03-23 22:56:44 missing history for pg_exec_query_string()