Re: [DOCS] Doc fixes and improvements

From: Thom Brown <thom(at)linux(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL www <pgsql-www(at)postgresql(dot)org>
Subject: Re: [DOCS] Doc fixes and improvements
Date: 2010-09-10 19:59:03
Message-ID: AANLkTik0i54fg1PY984+iqvc0YfWWyyMQY18QTf8S0eo@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-www

On 10 September 2010 20:50, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Thom Brown wrote:
>> >> >> Actually, that wasn't entirely true. ?I have to re-adapt it for the
>> >> >> current site as my changes were for the new version of the site which
>> >> >> we're not using yet. ?I think it's just a case of changing one line
>> >> >> from last I checked. ?Not sure where to take that though as I don't
>> >> >> have a working copy of the current site.
>> >> >
>> >> > Find me on IRC sometime and we can work that out - especially if you
>> >> > can get to the point of having a patch ready to debug :-)
>> >>
>> >> Ok, Thom has merged these changes onto the current website code, and
>> >> I've put it up on http://magnus.webdev.postgresql.org - note that you
>> >> need to go back to 8.3 to actually see anything, because the db
>> >> doesn't have the latest docs.
>> >
>> > I don't see the fix for javascript font size for Firefox fixed-width
>> > fonts:
>> >
>> > ? ? ? ?http://magnus.webdev.postgresql.org/docs/8.3/static/sql-syntax-lexical.html
>> >
>> > Is that installed? ?I assmume not.
>>
>> I just checked and the existing geckostyle.js is present, as well as
>> the geckofixes.css it's supposed to introduce.  I also disabled
>> javascript in Firefox to see the effect, and the monospace fonts are
>> very small (previously looked fine), so the script appears to be
>> working.
>>
>> Remember that the script for the live site (geckostyle.js) has a
>> different name to the upcoming site (monospacefix.js) which I was
>> hosting before.
>
> OK, here is what I see:
>
>        http://momjian.us/tmp/pg_manual.png
>
> I have font size of 14, with fixed size of 12 in my Firefox preferences.
>
> If I turn off javascript is looks more consistent:
>
>        http://momjian.us/tmp/pg_manual2.png

The font size shown in your 2nd screenshot looks smaller than the
existing docs. I did a comparison of Magnus' version and the live
version. The same monospace example in both renders the font as
precisely a calculated 12.7667px.

In fact it looks more like the proportional font is too small. My
value for that is still at the default value of 16. Does yours
differ?

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Bruce Momjian 2010-09-10 20:03:25 Re: [DOCS] Doc fixes and improvements
Previous Message Bruce Momjian 2010-09-10 19:50:32 Re: [DOCS] Doc fixes and improvements

Browse pgsql-www by date

  From Date Subject
Next Message Bruce Momjian 2010-09-10 20:03:25 Re: [DOCS] Doc fixes and improvements
Previous Message Bruce Momjian 2010-09-10 19:50:32 Re: [DOCS] Doc fixes and improvements