Re: more buildfarm breakage

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: more buildfarm breakage
Date: 2011-02-04 20:11:53
Message-ID: AANLkTik+7pSpvgGuU4JUQ_MdAzh6bCw3=RXRrBmEaZGj@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 4, 2011 at 1:16 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Feb 4, 2011 at 1:04 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I agree, that is not cool.
>
> OK, changed.

It looks like pipe.c is full of backend-specific error-reporting code.
I could rewrite it to work in the frontend, but since it's obviously
not used anywhere there it seems like an exercise in futility.

The viable options appear to be:

1. Use #ifndef FRONTEND to dike out the entire file.
2. Make a small change to the Makefile to only compile this into the
backend version of the library, and just skip it for the frontend
version.
3. Move it into src/backend/port.

My first thought is to go with #3.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-02-04 20:34:47 Re: Extensions support for pg_dump, patch v27
Previous Message Dimitri Fontaine 2011-02-04 19:51:38 Re: Use a separate pg_depend.deptype for extension membership?