| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org> |
| Subject: | Re: wip: functions median and percentile |
| Date: | 2010-09-21 20:44:16 |
| Message-ID: | AANLkTi=3B52S_ps+73NQX_dVg-s7htCKu3K=vq1hJJ_S@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-rrreviewers |
On Tue, Sep 21, 2010 at 4:28 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> * Cosmetic coding style should be more appropriate, including trailing
>> white spaces and indentation positions.
>
> can you specify where, please?
I noticed a lot of problems in this area when working on your \ef /
\sf patch, too. Trailing whitespace is nearly always bad, and it's
not hard to find - just grep the diff for it. As for indentation, try
to match the surrounding code.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pei He | 2010-09-21 21:02:53 | Get the offset of a tuple inside a table |
| Previous Message | Pavel Stehule | 2010-09-21 20:28:15 | Re: wip: functions median and percentile |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2010-09-21 21:03:31 | Re: wip: functions median and percentile |
| Previous Message | Pavel Stehule | 2010-09-21 20:28:15 | Re: wip: functions median and percentile |