Re: Git cvsserver serious issue

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Aidan Van Dyk <aidan(at)highrise(dot)ca>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Git cvsserver serious issue
Date: 2010-10-12 19:57:01
Message-ID: AANLkTi=v-cyod0uh9YS1zXrg3+H_fJM_6we1DLh7B+YN@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: buildfarm-members pgsql-hackers

On Fri, Oct 8, 2010 at 08:09, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Fri, Oct 8, 2010 at 03:52, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>
>>
>> On 10/07/2010 03:37 PM, Magnus Hagander wrote:
>>>
>>> On Thu, Oct 7, 2010 at 21:31, Andrew Dunstan<andrew(at)dunslane(dot)net>  wrote:
>>>>
>>>> On 10/07/2010 10:11 AM, Magnus Hagander wrote:
>>>>>><
>>>>>> OTOH, this patch seems pretty small and simple to maintain.
>>>>>
>>>>> True, it is rather small.
>>>>>
>>>>> Does anybody know if there's an automated way to maintain that on
>>>>> freebsd ports, and if so, how that works? I want to be *sure* we can't
>>>>> accidentally upgrade git-cvsserver *without* the patch, since that is
>>>>> a security issue.
>>>>>
>>>> Why not just make a local copy somewhere else and patch and run that?
>>>> It's
>>>> just a Perl script, no?
>>>
>>> Yeah, but then we have to remember to manually patch that one when
>>> somebody *else* finds/fixes a security issue. We have automatic
>>> monitoring on the ports stuff to detect when that happens..
>>
>> There's a simpler solution which I have just tested. Instead of patching,
>> use the Pg driver instead of SQLite. Set the dbname to %m. If the database
>> doesn't exist the cvs checkout will fail. So we just set up databases for
>> the modules we want to export (master and RELn_m_STABLE for the live
>> branches).
>
> A database per branch seems like a horrible idea in general, but if it
> works us around the bug, it seems like a doable idea.. As long as
> we'll never have a branch called "postgres" or "git" (already in use
> on that box).
>
> I'll look into it.

Should be up and working now. master branch is ready, working on
prepping rel9_0_stable.

CVSROOT is :pserver:anonymous(at)git(dot)postgresql(dot)org:/postgresql.git

module name is master or REL9_0_STABLE. master available now,
rel_9_0_stable sohuld be available in about half an hour.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse buildfarm-members by date

  From Date Subject
Next Message Andrew Dunstan 2010-10-12 21:07:12 Re: Git cvsserver serious issue
Previous Message Andrew Dunstan 2010-10-08 15:03:02 Re: Git cvsserver serious issue

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2010-10-12 20:05:57 Re: Debugging initdb breakage
Previous Message Dimitri Fontaine 2010-10-12 19:50:22 Re: Which file does the SELECT?