From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Indent authentication overloading |
Date: | 2011-03-19 16:02:15 |
Message-ID: | AANLkTi=rjZeuqiBgLRNmeZmTDkJ3V0M4vmY_VGik=FiV@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Mar 19, 2011 at 16:24, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Here's an updated patch that removes this log message, and adds a few
>> lines to initdb to create a combination of ident/peer rows. And
>> finally, adds docs.
>
>> Comments?
>
> As near as I can tell (I hate reading u-style diffs) you've documented
Ah, apologies. I made a -c diff, found a typo, remade it as -u.. pfft.
> the ident and peer keywords as being mutually exclusive, ie, the docs
> say that the correct keyword for the connection type *must* be used in
> pg_hba.conf. Which is not how the code behaves, and shouldn't be how
> the code behaves, for backwards-compatibility reasons. The docs need
> to state the truth, namely that "ident" is still allowed as a synonym
> for "peer" on local connections. Otherwise people will get confused
> as to why their pg_hba files still work.
Hmm: Good point, update attached.
> The code changes look sane in a quick scan, though I didn't read them
> in detail.
Thx.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
Attachment | Content-Type | Size |
---|---|---|
ident2peer.patch | text/x-patch | 25.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-03-19 16:39:03 | Re: Indent authentication overloading |
Previous Message | Magnus Hagander | 2011-03-19 15:47:23 | Re: odd output of pg_basebackup |