Re: log_checkpoints and restartpoint

On Wed, Jan 26, 2011 at 7:59 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Wed, 2011-01-26 at 13:14 +0900, Fujii Masao wrote:
>
>> When log_checkpoints is enabled, checkpoint logs the number of
>> WAL files created/deleted/recycled, but restartpoint doesn't.
>> This is OK before 9.0 because restartpoint had never created/
>> deleted/recycled WAL files. But, in 9.0 or later, restartpoint might
>> do that while walreceiver is running. So I think that it's useful to
>> log those numbers even in restartpoint in the now.
>>
>> The attached patch changes LogCheckpointEnd so that it logs
>> the number of WAL files created/deleted/recycled even in
>> restartpoint.
>>
>> And I found the problem about the initialization of CheckpointStats
>> struct. The attached patch also fixes this.
>
> Thanks.
>
> Can you add to CF app so we can track this as well? It's easier to track
> everything in one place.

Sure.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center