From: | Joachim Wieland <joe(at)mcknight(dot)de> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, José Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: directory archive format for pg_dump |
Date: | 2010-11-29 05:11:46 |
Message-ID: | AANLkTi=neaBqvLa2ZnDpuAMSen3P4ZHE8__Q7L2pmjD0@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Nov 22, 2010 at 3:44 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> * wrap long lines
> * use extern in function prototypes in header files
> * "inline" some functions like _StartDataCompressor, _EndDataCompressor,
> _DoInflate/_DoDeflate that aren't doing anything but call some other
> function.
So here is a new round of patches. It turned out that the feature to
allow to also restore files from a different dump and with a different
compression required some changes in the compressor API. And in the
end I didn't like all the #ifdefs either and made a less #ifdef-rich
version using function pointers. The downside now is that I have
created quite a few one-line functions that Heikki doesn't like all
that much, but I assume that they are okay in this case on the grounds
that the public compressor interface is calling the private
implementation of a certain compressor.
Joachim
Attachment | Content-Type | Size |
---|---|---|
pg_dump-compression-refactor.diff | text/x-patch | 37.6 KB |
pg_dump-directory.diff | text/x-patch | 68.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2010-11-29 06:10:38 | On-the-fly index tuple deletion vs. hot_standby |
Previous Message | Tom Lane | 2010-11-29 04:51:43 | Re: profiling connection overhead |