Re: BUG #5608: array_agg() consumes too much memory

2010/8/14 Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>:
> 2010/8/10 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> Eventually it might be nice to have some sort of way to specify the
>> estimate to use for any aggregate function --- but for a near-term
>> fix maybe we should just hard-wire a special case for array_agg in
>> count_agg_clauses_walker().
>
> The attached patch is the near-term fix; it adds ALLOCSET_DEFAULT_INITSIZE
> bytes to memory assumption.
>
> We might need the same adjustment for string_agg(), that consumes
> 1024 bytes for the transit condition. array_agg() and string_agg()
> are only aggregates that have "internal" for aggtranstype.

So, is it better to generalize as it adds ALLOCSET_DEFAULT_INITSIZE if
the transtype is internal, rather than specifying individual function
OID as the patch stands?

Regards,

--
Hitoshi Harada