Re: psql \conninfo command (was: Patch: psql \whoami option)

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: David Christensen <david(at)endpoint(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Steve Singer <ssinger_pg(at)sympatico(dot)ca>, pgsql-hackers Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql \conninfo command (was: Patch: psql \whoami option)
Date: 2010-07-22 03:13:48
Message-ID: AANLkTi=YKHuGsh8ih-F04OJnj+P9byPKug-2Tb1Od8XP@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 22, 2010 at 11:57 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Should we be using is_absolute_path() here instead, as libpq does?

Yes. The attached patch does that.

>> On Wed, Jul 21, 2010 at 10:09 PM, David Christensen <david(at)endpoint(dot)com> wrote:
>> If we print the local socket when it's been explicitly set via the host= param, why not display the actual socket path in the general local socket case?
>
> Patch?

Done. DEFAULT_PGSOCKET_DIR (i.e., /tmp) should be displayed in that
case, I think.

$ psql -c"\conninfo"
You are connected to database "postgres" via local socket on
"/tmp" at port "5432" as user "postgres".

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
conninfo_local_socket_v2.patch application/octet-stream 2.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-07-22 04:37:20 Re: Preliminary review of Synchronous Replication patches
Previous Message David Christensen 2010-07-22 03:06:33 Re: Explicit psqlrc