From: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Cc: | Rushabh Lathia <rushabh(dot)lathia(at)enterprisedb(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Subject: | edb-postgres.exe has encountered a problem on windows |
Date: | 2011-04-01 13:14:33 |
Message-ID: | AANLkTi=NatGM-Q+=4Fe5M2auYoWyhacxwvgx2ttjkqwJ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Problem:
========
On windows when we run edb-postgres.exe without any command line args, its
getting crash or its showing error into Application logs of Event Viewer.
Analysis:
==========
For any stderr we call the write_stderr() and write_stderr() calls the
write_console() for stderr. Now here write_console() using the palloc()
internally, which require the CurrentMemoryContext.
At the startup CurrentMemoryContext will be NULL, so palloc again calling
write_stderr(). So recursion has been started and its ending up with
exception.
Call stack for palloc() is:
main() -> check_root() -> write_stderr() -> write_console() ->
pgwin32_toUTF16() -> palloc()
Fix:
=====
Earlier we used to call vfprintf() for windows stderr, which is now
replaced with write_console().
So to avoid the exception now, I added condition for CurrentMemoryContext
into write_stderr().
PFA patch to fix the same.
Regards,
Rushabh Lathia
EnterpriseDB <http://www.enterprisedb.com/>, The Enterprise
PostgreSQL<http://www.enterprisedb.com/>
company.
Attachment | Content-Type | Size |
---|---|---|
win_crash_fix.patch | text/x-diff | 955 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2011-04-01 13:21:07 | Re: edb-postgres.exe has encountered a problem on windows |
Previous Message | Thom Brown | 2011-04-01 12:13:54 | Re: Foreign table permissions and cloning |