| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org, Daniel Farina <daniel(at)heroku(dot)com> |
| Subject: | Re: Sync Rep v17 |
| Date: | 2011-03-01 06:51:59 |
| Message-ID: | AANLkTi=Eu_s6BF7dzvNG_X2+6tc_qbBgn3mveBt5ih19@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for update of the patch!
On Tue, Mar 1, 2011 at 3:40 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> SyncRepRemoveFromQueue seems not to be as short-term as we can
>> use the spinlock. Instead, LW lock should be used there.
You seem to have forgotten to fix the above-mentioned issue.
A spinlock can be used only for very short-term operation like
read/write of some shared-variables. The operation on the queue
is not short, so should be protected by LWLock, I think.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2011-03-01 07:28:31 | Re: Sync Rep v17 |
| Previous Message | Fujii Masao | 2011-03-01 06:25:42 | Re: Sync Rep v17 |