From: | Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: git_topo_order script, to match up commits across branches. |
Date: | 2010-09-24 22:53:01 |
Message-ID: | AANLkTi=B9APBSxiOjQx9w6KQPdVysFHg54-+Un5xVyH7@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Sep 24, 2010 at 6:09 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com>wrote:
> Excerpts from Tom Lane's message of vie sep 24 17:36:59 -0400 2010:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > > On Sep 24, 2010, at 3:32 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > >> BTW ... I don't especially care for the name you picked for this
> script.
> > >> The fact that it does a topological sort is an implementation detail
> > >> that its users couldn't care less about, especially since that doesn't
> > >> matter except for corner cases. How about "collate_git_log" or
> > >> something along it.
> >
> > > I don't think that's any better - collate could mean anything - but I
> don't think it's any worse, either. Change it if you want.
> >
> > Well, I definitely think that the name should suggest a connection to
> > "git log". I agree that "collate" might not be the best possible verb
> > here --- anyone have a better suggestion?
>
> How about something content-free like "pg_git_log"?
>
If it resembles cvs2cl then why not name it git2cl? Or git_changelog.
Since it doesn't do anything specific to Postgres' git, lets not have any pg
in there.
Regards,
--
gurjeet.singh
@ EnterpriseDB - The Enterprise Postgres Company
http://www.EnterpriseDB.com
singh(dot)gurjeet(at){ gmail | yahoo }.com
Twitter/Skype: singh_gurjeet
Mail sent from my BlackLaptop device
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2010-09-24 23:28:53 | Re: [HACKERS] Re: pgsql: git_topo_order script, to match up commits across branches. |
Previous Message | Alvaro Herrera | 2010-09-24 22:09:48 | Re: pgsql: git_topo_order script, to match up commits across branches. |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2010-09-24 23:28:53 | Re: [HACKERS] Re: pgsql: git_topo_order script, to match up commits across branches. |
Previous Message | Alvaro Herrera | 2010-09-24 22:09:48 | Re: pgsql: git_topo_order script, to match up commits across branches. |