| From: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
|---|---|
| To: | Jan Urbański <wulczer(at)wulczer(dot)org> |
| Cc: | Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pl/python quoting functions |
| Date: | 2011-02-04 17:10:21 |
| Message-ID: | AANLkTi=8LX2-=8jD3wpbMTD_=Q-U-0nG3B9Hj8_L2awC@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2011/1/11 Jan Urbański <wulczer(at)wulczer(dot)org>:
> Here's a patch that adds a few PL/Python functions for quoting strings.
> It's an incremental patch on top of the plpython-refactor patch sent in
> http://archives.postgresql.org/message-id/4D135170.3080705@wulczer.org.
>
> Git branch for this patch:
> https://github.com/wulczer/postgres/tree/functions
>
> The new functions are plpy.quote_literal, plpy.quote_nullable and
> plpy.quote_ident, and work just like their sql or plperl equivalents.
>
I reviewed this.
The patch applies and compiles cleanly and all the tests are passed.
The patch adds 3 functions which works as the corresponding SQL
functions. The test is enough, without any additional docs. No
feature/performance issues found.
I mark this "Reader for Committer".
Regards,
--
Hitoshi Harada
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-02-04 17:17:32 | more buildfarm breakage |
| Previous Message | Oleg Bartunov | 2011-02-04 17:02:58 | Re: CommitFest progress - or lack thereof |