Re: autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.)

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jan Urbański <wulczer(at)wulczer(dot)org>, pgsql-hackers(at)postgresql(dot)org, Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp>
Subject: Re: autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.)
Date: 2011-02-04 03:37:13
Message-ID: AANLkTi=1HCsny0GHgPbVdM4pqQE6QK2TE-ByDF4cyCTK@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sun, Jan 30, 2011 at 6:27 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Just in a quick read-through of the patches, the only things I noticed
>
> Oh, a third thing: the patch places errcodes.txt under src/include,
> which does not seem even approximately right.  src/backend/utils
> seems like a saner place for it.

All right, committed after fixing merge conflicts and, I hope, taking
sensible actions based on your comments.

Oh, shoot, I forgot to add the copyright notice to errcodes.txt. Let
me fix that...

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2011-02-04 03:38:25 pgsql: Preserve copyright notice from old errcodes.h file.
Previous Message Robert Haas 2011-02-04 03:35:55 pgsql: Avoid maintaining three separate copies of the error codes list.

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2011-02-04 03:40:31 Re: [HACKERS] Slow count(*) again...
Previous Message Mark Mielke 2011-02-04 03:31:35 Does auto-analyze work on dirty writes? (was: Re: [HACKERS] Slow count(*) again...)